Review Board 1.7.16


Use spaces to format XML and create SIPpVersion class

Review Request #1049 - Created Dec. 7, 2010 and submitted

Paul Belanger
team/pabelanger/sipp
Reviewers
asterisk-dev
testsuite
After running into some issue getting the testsuite running under Ubuntu 8.04, it seemed older versions of SIPp fail to parse tabs (/t) properly. So, I replaced them with 4 spaces.

I then ran into an issue of failing tests because my SIPp version did not have the appropriate compile time flags enabled, so I created a new SIPpVersion parser.  I used the AsteriskVersion class as a template, also creating various unit tests to test the parser (very cool and fun BTW).  I've defaulted our SIPp based tests to 'v3.0' however I know some will require TLS, PCAP or both.  Will need help to confirm which will use it.

Feedback is required :)
local Ubuntu, FreeBSD and CentOS system.
asterisk/trunk/lib/python/sipp/version.py
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/app_dial_G_flag/test-config.yaml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/app_dial_G_flag/sipp/call.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/app_dial_G_flag/sipp/wait-for-call.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/app_queue/test-config.yaml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/app_queue/sipp/call.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/app_queue/sipp/call-then-hangup.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/app_queue/sipp/wait-for-call-hangup.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/blind-transfer-accountcode/test-config.yaml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/call-then-blind-transfer.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/register.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/wait-for-call.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/blind-transfer-accountcode/sipp/wait-for-call-do-hangup.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/originate-cdr-disposition/test-config.yaml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-busy.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-congestion.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml
Diff Revision 2 Diff Revision 3
 
asterisk/trunk/tests/queues/position_priority_maxlen/test-config.yaml
Diff Revision 2 Diff Revision 3
 
  1. asterisk/runtests.py: Loading...
  2. asterisk/lib/python/sipp/version.py: Loading...
  3. asterisk/tests/cdr/app_dial_G_flag/test-config.yaml: Loading...
  4. asterisk/tests/cdr/app_dial_G_flag/sipp/call.xml: Loading...
  5. asterisk/tests/cdr/app_dial_G_flag/sipp/wait-for-call.xml: Loading...
  6. asterisk/tests/cdr/app_queue/test-config.yaml: Loading...
  7. asterisk/tests/cdr/app_queue/sipp/call.xml: Loading...
  8. asterisk/tests/cdr/app_queue/sipp/call-then-hangup.xml: Loading...
  9. asterisk/tests/cdr/app_queue/sipp/wait-for-call-hangup.xml: Loading...
  10. asterisk/tests/cdr/blind-transfer-accountcode/test-config.yaml: Loading...
  11. asterisk/tests/cdr/blind-transfer-accountcode/sipp/call-then-blind-transfer.xml: Loading...
  12. asterisk/tests/cdr/blind-transfer-accountcode/sipp/register.xml: Loading...
  13. asterisk/tests/cdr/blind-transfer-accountcode/sipp/wait-for-call.xml: Loading...
  14. asterisk/tests/cdr/blind-transfer-accountcode/sipp/wait-for-call-do-hangup.xml: Loading...
  15. asterisk/tests/cdr/originate-cdr-disposition/test-config.yaml: Loading...
  16. asterisk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call.xml: Loading...
  17. asterisk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-busy.xml: Loading...
  18. asterisk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-congestion.xml: Loading...
  19. asterisk/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml: Loading...
  20. asterisk/tests/queues/position_priority_maxlen/test-config.yaml: Loading...
This diff has been split across 2 pages: 1 2 >

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.