Review Board 1.7.16


Generate VMWI neon pulses from FXS module to light NEON lamp on older 'non intellegent phones'

Review Request #1144 - Created March 16, 2011 and updated

Alec Davis
dahdi/linux
14261
Reviewers
asterisk-dev
sruffell
DAHDI
Implement same code as for wcdtm
13/04/12
Tested with mwisendtype=lrev,hvac
at 2 different phones on same FXS port, one a real neon phone, and another a led+zener phone.
Left messages, and neon would flash as expected.
Review request changed
Updated (April 13, 2012, 12:37 a.m.)
  • 13/04/12
    Tested with mwisendtype=lrev,hvac
    at 2 different phones on same FXS port, one a real neon phone, and another a led+zener phone.
    Left messages, and neon would flash as expected.
    
    There is an issue that I think exists with the wctdm code as well, that is with some messages already waiting, thus neon is flashing, if another caller aborts the call and doesn't leave a message, the set_vmwi isn't called to re-enable the neon, the lrev is set correctly though.

    13/04/12
    Tested with mwisendtype=lrev,hvac
    at 2 different phones on same FXS port, one a real neon phone, and another a led+zener phone.
    Left messages, and neon would flash as expected.
    
Fix the issue where the neon would not relight after an aborted call.
Posted (April 30, 2012, 9:47 a.m.)
There are quite a few missing braces around ifs and elses, but I don't quite remember the coding guidelines for the DAHDI project, so those may not be an issue.
  1. They use the Linux kernel coding guidelines. http://www.kernel.org/doc/Documentation/CodingStyle
    See chapter 3 of the linked document. In most cases, single statement blocks get no braces. The exception is if, say, there is an if block with multiple statements with an else with only one statement. The else in that case would get braces since the if block also got braces.
    
    That document annoys me because of the constant rationale of "K&R did it that way so it must be right" .
This should be removed.
Ditto.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.