Review Board 1.7.16


Access to any Exchange 2007 and 2010 calendar.

Review Request #1152 - Created March 29, 2011 and updated

astmiv
Reviewers
asterisk-dev
pitlicek@gmail.com
Asterisk
This patch will add access to any calendar folder within Exchange 2007 and 2010. 

The current resource only gives access to the default calendar folder of the specified user. With this patch it is possible to access any calendar folder within the system as long as the user has read rights to the folder and its complete folder path.

For example:
- Calendar folders below the publicfoldersroot.
- Calendar folders below the user's mailbox outside of his default calendar.
- Calendar folders below the user's default calendar.
- etc....

Also did some cleanup for XML schema labeling. They are now all the same.
Tested the following scenario's:
- Access to default calendar of specified user. (folderbase not specified or folderbase=calendar)
- Access to shared default calendar of other person. (mailbox=emailother@company.com and folderbase not specified or folderbase=calendar)
- Access to calendar folder, named testfolder1, below default Calendar. (folderbase=calendar and folderpath=/testfolder1)
- Access to calendar folder, named testfolder2, below a subfolder, named testfolder3, of the default Calendar. (folderbase=calendar and folderpath=/testfolder3/testfolder2)
- Access to calendar folder in Public Folders. (folderbase=publicfoldersroot and folderpath=/meetingroom1)
- Access to calendar folder below a subfolder in Public Folders. (folderbase=publicfoldersroot and folderpath=/meetingrooms/meetingroom1)
- Access to calendar folder below mailbox of specified user. (folderbase=msgfolderroot and folderpath=/calendar2)
Total:
24
Open:
24
Resolved:
0
Dropped:
0
Status:
From:
Description From Last Updated Status
Clean up the red space here. Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
This function seems significant enough that it could use a little XML documentation. I know little else in this module ... Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
trailing red space here. Plus we usually close function calls on the last name containing arguments. Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
XML Documentation Also this function is really large. Consider refactoring it and breaking it into smaller chunks. That might help ... Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
I'm not sure if this is a useful debug message. It should probably be removed since it isn't pointing anything ... Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
red space here. Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
and here. Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
Mixed tabs and spaces. Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
trailing whitespace Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
I don't love the huge stacks of cleanup going on here at every failure step. Perhaps you could just have ... Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
trailing whitespace. Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
Trailing whitespace Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
Trailing whitespace, plus we usually close function calls on the last line with an argument rather than like we do ... Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
I don't think there is any need to have both the debug log message and the warning log message. If ... Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
As above Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
As above Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
As above Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
whitespace Jonathan Rose Aug. 15, 2014, 6:13 p.m. Open
;mailbox spacing isn't uniform with the rest of this block. Also it looks like "; Primary SMTP address [...]" might ... Jonathan Rose Aug. 20, 2014, 4:53 p.m. Open
-folderpath= /meetingroom1 +folderpath = /meetingroom1 Jonathan Rose Aug. 20, 2014, 4:53 p.m. Open
fflush appears to be misaligned by a tab. Jonathan Rose Aug. 20, 2014, 4:53 p.m. Open
here too. Jonathan Rose Aug. 20, 2014, 4:53 p.m. Open
You missed a spot :P Jonathan Rose Aug. 20, 2014, 4:53 p.m. Open
There shouldn't be a blank line between XML docs and the function. Jonathan Rose Aug. 20, 2014, 4:53 p.m. Open
Review request changed
Updated (Aug. 20, 2014, 3:51 a.m.)
One last white space clean up.
Posted (Aug. 20, 2014, 4:53 p.m.)

   

  
;mailbox

spacing isn't uniform with the rest of this block. Also it looks like "; Primary SMTP address [...]" might be meant to have a line break. Line 79 runs a little long, so break it before the URL.

Write casesensitive as 'case-sensitive' or 'case sensitive' (I think both are technically 
/trunk/configs/samples/calendar.conf.sample (Diff revision 5)
 
 
 
-folderpath= /meetingroom1
+folderpath = /meetingroom1
/trunk/res/res_calendar_ews.c (Diff revision 5)
 
 
 
 
fflush appears to be misaligned by a tab.
/trunk/res/res_calendar_ews.c (Diff revision 5)
 
 
 
here too.
/trunk/res/res_calendar_ews.c (Diff revision 5)
 
 
You missed a spot :P
/trunk/res/res_calendar_ews.c (Diff revision 5)
 
 
 
 
There shouldn't be a blank line between XML docs and the function.
Aside from these style issues, this looks good to go to me. It'd be good to have someone with some experience with Exchange to take a look at it, but I don't believe that's a luxury we have.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.