Review Board 1.7.16


[18801] - features reload does not clear old configuration and always include 700 on parkedcalls : patch

Review Request #1161 - Created April 6, 2011 and submitted

Jonathan Rose
18801
Reviewers
asterisk-dev
dvossel, rbyrant
Asterisk
This fix follows a completely different approach from the other one, so I created a new review request.
This fix involves wiping all the parking lots in the parkinglots ao2_container while purging their extensions so that they have to be rebuilt when features reload is performed.

I have a bit more confidence in this one.  It's much more additive and much less destructive than the last one.
Tested with multiple parking lots, changing multiple parking lots, with and without [general], with general and then without general and then with general again (which showed a need for an additional change), and mixes of all the above.
Review request changed
Updated (April 6, 2011, 10:06 a.m.)
Changes made based on the suggestions of David Vossel
Posted (April 6, 2011, 10:09 a.m.)

   

  
/trunk/main/features.c (Diff revision 2)
 
 
note:  added an extra set of parens around this due to warning I didn't notice about extra parens around truth values
Ship it!
Posted (April 6, 2011, 10:52 a.m.)
Great work!  I have one comment that needs to be addressed before shipping it though.
/trunk/main/features.c (Diff revision 2)
 
 
 
 
destroy the iterator after the while loop

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.