Review Board 1.7.16


Add 'description' field for SIP peers

Review Request #1163 - Created April 6, 2011 and submitted

Leif Madsen
trunk
19076
Reviewers
asterisk-dev
oej
Asterisk
Using some of the best practices names for SIP peers provides the quandary of knowing exactly what peer is where, or who it is assigned to.

If you name all your peers as the MAC address of the device, then it's difficult to determine what device is assigned to whom, or at least knowing where the device physically resides.

I've added a description field that can help. When you do 'sip show peers' then a new column called Description outputs 32 chars of a description to the Asterisk console.
Added "description=My Awesome Peer" to [0004f2040001] definition in sip.conf, then did 'sip show peers' and 'sip show peer 0004f2040001'. Output was as expected. Compiled without error or warning.
Review request changed
Updated (April 8, 2011, 2:35 a.m.)
Make changes based on rmudgett's review. Thanks!
Ship it!
Posted (April 8, 2011, 8:20 a.m.)
Looks good enough to me.
Ship it!
Posted (April 11, 2011, 5:42 a.m.)
Looks good to me.  Thanks for helping us all follow best practices!

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.