Review Board 1.7.16


0019287: inverse / incorrect behavior for CLI / console logging of DTMF

Review Request #1244 - Created June 1, 2011 and submitted

Jonathan Rose
1.8
19287
Reviewers
asterisk-dev
dvossel, russell
Asterisk
ast_network_puts_mutable writes to a connected console client only if it's level was set to false.  This changes that function to write it only if it is set to true to resolve the reverse behavior from expectations issue.

This seems like the way to go, but I can't see for the life of me why this mistake would be made if it really was just a mistake.  It's hard to say.
Just tested with a couple of connected clients.  I'll test more tomorrow.
Review request changed
Updated (June 6, 2011, 4:36 a.m.)
Changed to use ternary instead of mod.
Ship it!
Posted (June 6, 2011, 4:37 a.m.)

   

  

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.