Review Board 1.7.16


Workaround for Google Talk protocol change

Review Request #1312 - Created July 6, 2011 and submitted

Terry Wilson
1.8
Reviewers
asterisk-dev
dvossel
Asterisk
Calls from a GMail client now offer both a jingle session and the old-style session. This patch detects this and ignores the jingle session and uses the other session instead.

It looks like they are now trying to use the actual Jingle spec, so we will want to take a look at writing a parser for that once they start using it for both GTalk and Google Voice. There are some differences with the temporary one that chan_jingle uses.

This fix is a little hacky, but that is just how it goes until they actually switch to "Real Jingle" everywhere.
I made inbound and outbound GTalk and Google Voice calls and they all rang through.
Ship it!
Posted (July 7, 2011, 5:11 a.m.)
Great work tracking this down.  This looks like it will work until they decide to not offer the old session type.  Perhaps someone can come along and write a parser for the new one before then.  Regardless, having things work now is always a good thing.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.