Review Board 1.7.16


New DUNDi cli commands to list cache entries

Review Request #1438 - Created Sept. 14, 2011 and submitted

Leif Madsen
10
ASTERISK-18390
Reviewers
asterisk-dev
pabelanger, russell
Asterisk
This patch adds the following cli commands for DUNDi:

dundi show cache: List DUNDi cache entries
dundi show hints: List DUNDi 'DONTASK' hints in the cache


(Developer is Peter Racz from JIRA)
I've tested this on my Asterisk 10 box, and the commands work as I would expect.
Review request changed
Updated (July 26, 2012, 6:44 a.m.)
Fix whitespace and reduce indentation
Posted (July 26, 2012, 6:46 a.m.)

   

  
branches/10/pbx/pbx_dundi.c (Diff revision 3)
 
 
 
 
 
 
 
fixing sneaky whitespace that I missed here.
Posted (July 26, 2012, 8:14 a.m.)

   

  
branches/10/pbx/pbx_dundi.c (Diff revision 3)
 
 
 
 
 
This could more naturally be expressed using a for loop:

for (db_entry = db_tree; db_entry; db_entry = db_entry->next)

That would also eliminate all the places where you have to manually traverse to the next entry in the db_tree.
  1. Check.
branches/10/pbx/pbx_dundi.c (Diff revision 3)
 
 
 
 
 
 
 
 
 
 
Don't increment count here.  If term is NULL, you'll skip this entry without printing it, but count it as a valid entry.
  1. Check.
branches/10/pbx/pbx_dundi.c (Diff revision 3)
 
 
Same finding here - write this as a for loop
  1. Check.
    
    I don't have control over this review, so I'm going to be posting patches to the issue until the reporter chimes in.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.