Review Board 1.7.16


Use the proper type for ast_codec_pref's framing field so that packetization values > 127 can be used

Review Request #1639 - Created Dec. 21, 2011 and submitted

Terry Wilson
1.8
ASTERISK-18876
Reviewers
asterisk-dev
Asterisk
ast_codec_pref has a framing field that is set as a signed char array even though every place in the code treats it as an int array. This just changes the field to an int array. It uses a magic number, but it is essentially the same thing that was there before. We could probably move the AST_FORMAT_LIST into the header and use its ARRAY_LEN as the size so that things are no bigger than they need to be. I figured I'd go with the smallest change first and see what people thought.
Made calls with allow=g729:230 and saw that it was used whereas before it looped around to a lower value.
Ship it!
Posted (Dec. 22, 2011, 3:48 a.m.)
Works for me.  Hard coded values like that usually scare me, but this '64' value will always be the case for 1.8.  Asterisk 10 uses a defined value for these arrays, so simply making it an int instead of a char should be fine.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.