Review Board 1.7.16


sync chan_dahdi->p->outgoing with sig_XXX->p-outgoing

Review Request #1747 - Created Feb. 15, 2012 and submitted

Alec Davis
1.8 and above
Reviewers
asterisk-dev
Asterisk
Jeremy Pepper review https://reviewboard.asterisk.org/r/1737/ highlighted an issue where p->outgoing flag isn't in sync between chan_dahdi and sig_analog
sig_analog: Basic calls in and out with analog TDM800P
sig_pri and sig_ss7: compiles
trunk/channels/chan_dahdi.c
Revision 353434 New Change
[20] 2274 lines
[+20] [+] static void my_set_dialing(void *pvt, int is_dialing)
2275
	struct dahdi_pvt *p = pvt;
2275
	struct dahdi_pvt *p = pvt;
2276

    
   
2276

   
2277
	p->dialing = is_dialing;
2277
	p->dialing = is_dialing;
2278
}
2278
}
2279

    
   
2279

   

    
   
2280
static void my_set_outgoing(void *pvt, int is_outgoing)

    
   
2281
{

    
   
2282
	struct dahdi_pvt *p = pvt;

    
   
2283

   

    
   
2284
	p->outgoing = is_outgoing;

    
   
2285
}

    
   
2286

   
2280
#if defined(HAVE_PRI) || defined(HAVE_SS7)
2287
#if defined(HAVE_PRI) || defined(HAVE_SS7)
2281
static void my_set_digital(void *pvt, int is_digital)
2288
static void my_set_digital(void *pvt, int is_digital)
2282
{
2289
{
2283
	struct dahdi_pvt *p = pvt;
2290
	struct dahdi_pvt *p = pvt;
2284

    
   
2291

   
[+20] [20] 1080 lines
[+20] [+] static struct sig_pri_callback dahdi_pri_callbacks =
3365
	.deadlock_avoidance_private = my_deadlock_avoidance_private,
3372
	.deadlock_avoidance_private = my_deadlock_avoidance_private,
3366
	.new_ast_channel = my_new_pri_ast_channel,
3373
	.new_ast_channel = my_new_pri_ast_channel,
3367
	.fixup_chans = my_pri_fixup_chans,
3374
	.fixup_chans = my_pri_fixup_chans,
3368
	.set_alarm = my_set_alarm,
3375
	.set_alarm = my_set_alarm,
3369
	.set_dialing = my_set_dialing,
3376
	.set_dialing = my_set_dialing,

    
   
3377
	.set_outgoing = my_set_outgoing,
3370
	.set_digital = my_set_digital,
3378
	.set_digital = my_set_digital,
3371
	.set_callerid = my_set_callerid,
3379
	.set_callerid = my_set_callerid,
3372
	.set_dnid = my_set_dnid,
3380
	.set_dnid = my_set_dnid,
3373
	.set_rdnis = my_set_rdnis,
3381
	.set_rdnis = my_set_rdnis,
3374
	.new_nobch_intf = dahdi_new_pri_nobch_channel,
3382
	.new_nobch_intf = dahdi_new_pri_nobch_channel,
[+20] [20] 160 lines
[+20] [+] static struct sig_ss7_callback dahdi_ss7_callbacks =
3535
	.play_tone = my_ss7_play_tone,
3543
	.play_tone = my_ss7_play_tone,
3536

    
   
3544

   
3537
	.handle_link_exception = my_handle_link_exception,
3545
	.handle_link_exception = my_handle_link_exception,
3538
	.set_alarm = my_set_alarm,
3546
	.set_alarm = my_set_alarm,
3539
	.set_dialing = my_set_dialing,
3547
	.set_dialing = my_set_dialing,

    
   
3548
	.set_outgoing = my_set_outgoing,
3540
	.set_digital = my_set_digital,
3549
	.set_digital = my_set_digital,
3541
	.set_inservice = my_set_inservice,
3550
	.set_inservice = my_set_inservice,
3542
	.set_locallyblocked = my_set_locallyblocked,
3551
	.set_locallyblocked = my_set_locallyblocked,
3543
	.set_remotelyblocked = my_set_remotelyblocked,
3552
	.set_remotelyblocked = my_set_remotelyblocked,
3544
	.set_callerid = my_set_callerid,
3553
	.set_callerid = my_set_callerid,
[+20] [20] 131 lines
[+20] [+] static struct analog_callback dahdi_analog_callbacks =
3676
	.get_sigpvt_bridged_channel = my_get_sigpvt_bridged_channel,
3685
	.get_sigpvt_bridged_channel = my_get_sigpvt_bridged_channel,
3677
	.get_sub_fd = my_get_sub_fd,
3686
	.get_sub_fd = my_get_sub_fd,
3678
	.set_cadence = my_set_cadence,
3687
	.set_cadence = my_set_cadence,
3679
	.set_alarm = my_set_alarm,
3688
	.set_alarm = my_set_alarm,
3680
	.set_dialing = my_set_dialing,
3689
	.set_dialing = my_set_dialing,

    
   
3690
	.set_outgoing = my_set_outgoing,
3681
	.set_ringtimeout = my_set_ringtimeout,
3691
	.set_ringtimeout = my_set_ringtimeout,
3682
	.set_waitingfordt = my_set_waitingfordt,
3692
	.set_waitingfordt = my_set_waitingfordt,
3683
	.check_waitingfordt = my_check_waitingfordt,
3693
	.check_waitingfordt = my_check_waitingfordt,
3684
	.set_confirmanswer = my_set_confirmanswer,
3694
	.set_confirmanswer = my_set_confirmanswer,
3685
	.check_confirmanswer = my_check_confirmanswer,
3695
	.check_confirmanswer = my_check_confirmanswer,
[+20] [20] 15275 lines
trunk/channels/sig_analog.h
Revision 353434 New Change
 
trunk/channels/sig_analog.c
Revision 353434 New Change
 
trunk/channels/sig_pri.h
Revision 353434 New Change
 
trunk/channels/sig_pri.c
Revision 353434 New Change
 
trunk/channels/sig_ss7.h
Revision 353434 New Change
 
trunk/channels/sig_ss7.c
Revision 353434 New Change
 
  1. trunk/channels/chan_dahdi.c: Loading...
  2. trunk/channels/sig_analog.h: Loading...
  3. trunk/channels/sig_analog.c: Loading...
  4. trunk/channels/sig_pri.h: Loading...
  5. trunk/channels/sig_pri.c: Loading...
  6. trunk/channels/sig_ss7.h: Loading...
  7. trunk/channels/sig_ss7.c: Loading...

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.