Review Board 1.7.16


sync chan_dahdi->p->outgoing with sig_XXX->p-outgoing

Review Request #1747 - Created Feb. 15, 2012 and submitted

Alec Davis
1.8 and above
Reviewers
asterisk-dev
Asterisk
Jeremy Pepper review https://reviewboard.asterisk.org/r/1737/ highlighted an issue where p->outgoing flag isn't in sync between chan_dahdi and sig_analog
sig_analog: Basic calls in and out with analog TDM800P
sig_pri and sig_ss7: compiles

Changes between revision 2 and 3

1 2 3 4 5
1 2 3 4 5

  1. trunk/channels/chan_dahdi.c: Loading...
  2. trunk/channels/sig_analog.h: Loading...
  3. trunk/channels/sig_analog.c: Loading...
trunk/channels/chan_dahdi.c
Diff Revision 2 Diff Revision 3
[20] 3633 lines
[+20] [+] static int my_have_progressdetect(void *pvt)
3634
		/* Don't have progress detection. */
3634
		/* Don't have progress detection. */
3635
		return 0;
3635
		return 0;
3636
	}
3636
	}
3637
}
3637
}
3638

    
   
3638

   
3639
static int my_is_outgoing(void *pvt)

   
3640
{

   
3641
	struct dahdi_pvt *p = pvt;

   
3642

    
   

   
3643
	if (p->outgoing) {

   
3644
		return 1;

   
3645
	}

   
3646
	return 0;

   
3647
}

   
3648

    
   

   
3649
static struct analog_callback dahdi_analog_callbacks =
3639
static struct analog_callback dahdi_analog_callbacks =
3650
{
3640
{
3651
	.play_tone = my_play_tone,
3641
	.play_tone = my_play_tone,
3652
	.get_event = my_get_event,
3642
	.get_event = my_get_event,
3653
	.wait_event = my_wait_event,
3643
	.wait_event = my_wait_event,
[+20] [20] 58 lines
[+20] static struct analog_callback dahdi_analog_callbacks =
3712
	.set_polarity = my_set_polarity,
3702
	.set_polarity = my_set_polarity,
3713
	.start_polarityswitch = my_start_polarityswitch,
3703
	.start_polarityswitch = my_start_polarityswitch,
3714
	.answer_polarityswitch = my_answer_polarityswitch,
3704
	.answer_polarityswitch = my_answer_polarityswitch,
3715
	.hangup_polarityswitch = my_hangup_polarityswitch,
3705
	.hangup_polarityswitch = my_hangup_polarityswitch,
3716
	.have_progressdetect = my_have_progressdetect,
3706
	.have_progressdetect = my_have_progressdetect,
3717
	.is_outgoing = my_is_outgoing,

   
3718
};
3707
};
3719

    
   
3708

   
3720
/*! Round robin search locations. */
3709
/*! Round robin search locations. */
3721
static struct dahdi_pvt *round_robin[32];
3710
static struct dahdi_pvt *round_robin[32];
3722

    
   
3711

   
[+20] [20] 15258 lines
trunk/channels/sig_analog.h
Diff Revision 2 Diff Revision 3
 
trunk/channels/sig_analog.c
Diff Revision 2 Diff Revision 3
 
  1. trunk/channels/chan_dahdi.c: Loading...
  2. trunk/channels/sig_analog.h: Loading...
  3. trunk/channels/sig_analog.c: Loading...

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.