Review Board 1.7.16


sync chan_dahdi->p->outgoing with sig_XXX->p-outgoing

Review Request #1747 - Created Feb. 15, 2012 and submitted

Alec Davis
1.8 and above
Reviewers
asterisk-dev
Asterisk
Jeremy Pepper review https://reviewboard.asterisk.org/r/1737/ highlighted an issue where p->outgoing flag isn't in sync between chan_dahdi and sig_analog
sig_analog: Basic calls in and out with analog TDM800P
sig_pri and sig_ss7: compiles

Changes between revision 4 and 5

1 2 3 4 5
1 2 3 4 5

  1. trunk/channels/chan_dahdi.c: Loading...
  2. trunk/channels/sig_analog.c: Loading...
trunk/channels/chan_dahdi.c
Diff Revision 4 Diff Revision 5
[20] 2278 lines
[+20] [+] static void my_set_dialing(void *pvt, int is_dialing)
2279

    
   
2279

   
2280
static void my_set_outgoing(void *pvt, int is_outgoing)
2280
static void my_set_outgoing(void *pvt, int is_outgoing)
2281
{
2281
{
2282
	struct dahdi_pvt *p = pvt;
2282
	struct dahdi_pvt *p = pvt;
2283

    
   
2283

   
2284
	ast_log(LOG_WARNING, "ALEC p->outgoing(%d) = %d\n", p->outgoing, is_outgoing);

   
2285
	p->outgoing = is_outgoing;
2284
	p->outgoing = is_outgoing;
2286
}
2285
}
2287

    
   
2286

   
2288
#if defined(HAVE_PRI) || defined(HAVE_SS7)
2287
#if defined(HAVE_PRI) || defined(HAVE_SS7)
2289
static void my_set_digital(void *pvt, int is_digital)
2288
static void my_set_digital(void *pvt, int is_digital)
[+20] [20] 1083 lines
[+20] [+] static struct sig_pri_callback dahdi_pri_callbacks =
3373
	.deadlock_avoidance_private = my_deadlock_avoidance_private,
3372
	.deadlock_avoidance_private = my_deadlock_avoidance_private,
3374
	.new_ast_channel = my_new_pri_ast_channel,
3373
	.new_ast_channel = my_new_pri_ast_channel,
3375
	.fixup_chans = my_pri_fixup_chans,
3374
	.fixup_chans = my_pri_fixup_chans,
3376
	.set_alarm = my_set_alarm,
3375
	.set_alarm = my_set_alarm,
3377
	.set_dialing = my_set_dialing,
3376
	.set_dialing = my_set_dialing,

    
   
3377
	.set_outgoing = my_set_outgoing,
3378
	.set_digital = my_set_digital,
3378
	.set_digital = my_set_digital,
3379
	.set_callerid = my_set_callerid,
3379
	.set_callerid = my_set_callerid,
3380
	.set_dnid = my_set_dnid,
3380
	.set_dnid = my_set_dnid,
3381
	.set_rdnis = my_set_rdnis,
3381
	.set_rdnis = my_set_rdnis,
3382
	.new_nobch_intf = dahdi_new_pri_nobch_channel,
3382
	.new_nobch_intf = dahdi_new_pri_nobch_channel,
[+20] [20] 160 lines
[+20] [+] static struct sig_ss7_callback dahdi_ss7_callbacks =
3543
	.play_tone = my_ss7_play_tone,
3543
	.play_tone = my_ss7_play_tone,
3544

    
   
3544

   
3545
	.handle_link_exception = my_handle_link_exception,
3545
	.handle_link_exception = my_handle_link_exception,
3546
	.set_alarm = my_set_alarm,
3546
	.set_alarm = my_set_alarm,
3547
	.set_dialing = my_set_dialing,
3547
	.set_dialing = my_set_dialing,

    
   
3548
	.set_outgoing = my_set_outgoing,
3548
	.set_digital = my_set_digital,
3549
	.set_digital = my_set_digital,
3549
	.set_inservice = my_set_inservice,
3550
	.set_inservice = my_set_inservice,
3550
	.set_locallyblocked = my_set_locallyblocked,
3551
	.set_locallyblocked = my_set_locallyblocked,
3551
	.set_remotelyblocked = my_set_remotelyblocked,
3552
	.set_remotelyblocked = my_set_remotelyblocked,
3552
	.set_callerid = my_set_callerid,
3553
	.set_callerid = my_set_callerid,
[+20] [20] 15417 lines
trunk/channels/sig_analog.c
Diff Revision 4 Diff Revision 5
 
  1. trunk/channels/chan_dahdi.c: Loading...
  2. trunk/channels/sig_analog.c: Loading...

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.