Review Board 1.7.16


Cleanup bridging and features code

Review Request #179 - Created Feb. 27, 2009 and submitted

KNK
/trunk
14503
Reviewers
asterisk-dev
Asterisk
This is a follow up to the changes made in http://reviewboard.digium.com/r/163/ plus some additional unrelated code cleanups (mostly in channel.c)

By having a dedicated timer for the features:
  firstapss is no longer needed, because start_time is no longer shared with the features and used for the start sounds instead.
  the backup config is no longer needed in order to disable the warnings, but the AST_FEATURE_WARNING_ACTIVE flag is used.
The backup_config.feature_timer was actually never used - the related code is removed now.
Activating a feature, feature timeout and non feature digits are working with and without timelimit involved and also before and after a warning is played without causing unexpected warnings or delaying the next warning.
Review request changed
Updated (March 2, 2009, 3:30 a.m.)
Fixed a forgotten feature_timer reset
Ship it!
Posted (March 3, 2009, 8:58 a.m.)
This looks good to me. All concerns noted on the bug have been addressed.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.