Review Board 1.7.16


chan_jingle2: New Jingle + Google Talk channel driver

Review Request #1917 - Created May 13, 2012 and submitted

Joshua Colp
chan_jingle2
Reviewers
asterisk-dev
Asterisk
This is a new channel driver written from scratch for the Jingle, Google Jingle, and Google Talk protocols. It has been written to the specs available and tested extensively.

ICE and STUN support for Jingle uses the new ICE/STUN/TURN support which is present in another review. (Please do not review any of that code in this review)
STUN support for Google uses the existing STUN implementation, as the new support is not compatible with it.
Tested audio calls with following:

GMail Google Talk Plug-in (and video)
Google Voice
Jitsi (and video)
Psi
OneTeam

* Included varying codecs (ulaw, speex, g722, etc)

Tested ringing, hold, and unhold with following:

Jitsi

Other clients do not support this.
Review request changed
Updated (June 21, 2012, 3:32 a.m.)
Incorporated latest minor changes.
Ship it!
Posted (June 26, 2012, 12:24 p.m.)
As with Mark's comment on res_xmpp, this could use another pair of eyes before it gets committed, but this looks good to me.
  1. We did realize this needs the new Call ID Logging functionality - but that could be done in a separate patch.
Ship it!
Posted (June 27, 2012, 9:55 a.m.)
Looks good other than the two issues below.
/channels/chan_jingle2.c (Diff revision 4)
 
 
This frame should be freed before it's address is forgotten.
/channels/chan_jingle2.c (Diff revision 4)
 
 
Add an AST_CONTROL_PVT_CAUSE_CODE to fallthrough with "case -1:" so that the message below isn't spammed nonstop.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.