Review Board 1.7.16


Allow disconnect feature before a call is bridged

Review Request #195 - Created March 16, 2009 and submitted

David Vossel
0011583
Reviewers
asterisk-dev
russell
Asterisk
res_feature's main procedure is called within ast_bridge_call().  This means features such as the disconnect action are only available after the bridge is established.  The goal of this patch is to use the user configured feature code during the call setup phase.

This patch was created by a community member, sobomax, and originally assigned to someone else before being assigned to me.  I've taken what I believe was latest code and cleaned up what I could.  There were quite a few instances of string allocation taking place on the heap where they could have taken place on the stack.  I believe I caught them all, but that would be something to look for.  I also had some concerns about the way locking was done.  In detect_disconnect() the channel wasn't locked when I believe it should have been.  For a moment, features and the channel must be locked at the same time.  I don't suspect this to a problem, but it would be nice if someone could verify my locking order.  Other than that, my main concern is not fully understanding the implications of this code.  I understand what it does, but not everything it could affect. 
I've tested the patch using the disconnect feature. Made a call and was able to successfully disconnect before bridging. 
Review request changed
Updated (March 18, 2009, 1:08 p.m.)
ffffffffffffffffffixed maybe
Ship it!
Posted (March 18, 2009, 1:24 p.m.)
Just fix this one problem and this will be ready to be merged. Great job, David!
/trunk/main/features.c (Diff revision 4)
 
 
This is not one of the acceptable changes I presented in my last review. Take a closer look at the two possible suggestions I made :)

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.