Review Board 1.7.16


WebSocket HTTP Module

Review Request #1952 - Created May 29, 2012 and submitted

Joshua Colp
websocket
Reviewers
asterisk-dev
Asterisk
This adds support for WebSocket protocols 7, 8, and 13. These are the most recent protocols. Sending and receiving text/binary frames is supported along with the various operation codes. An API is provided which makes it easy to implement different sub-protocols. Frame reconstruction is supported for situations where desirable (if multiple frames are received they will be reconstructed into a single one) but this can be disabled in situations where streaming is wanted.
Tested using Google Chrome Canary to confirm connection is established and data can be sent and received.

Tested using websocket.py to confirm connection is established and data can be sent and received.
Review request changed
Updated (May 30, 2012, 9:23 a.m.)
More feedback incorporated.
Ship it!
Posted (May 31, 2012, 5:13 a.m.)
Things look good now. I'll leave the points below to you.
/res/res_http_websocket.c (Diff revision 3)
 
 
Single red blob left.
/res/res_http_websocket.c (Diff revision 3)
 
 
Should this really be called 'chat' and not e.g. 'echo'?

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.