Review Board 1.7.16


Change T38 passthrough reinvite to use control frames

Review Request #200 - Created March 17, 2009 and submitted

Joshua Colp
branches/1.6.0/
Reviewers
asterisk-dev
Asterisk
This patch changes the T38 passthrough reinvite method to use the existing T38 control frames. It also fixes an issue where T38 was accepted even though the remote side may be an application that was not aware of it.
The following scenarios have been tested:

T38 Capable Device -> Asterisk -> Regular Phone - This scenario failed with a 488 which was expected
T38 Capable Device -> Asterisk -> T38 Capable Device - This scenario worked with T38 negotiated on both sides
T38 Capable Device -> Asterisk running an application - This scenario failed with a 488 which was expected
Review request changed
Updated (March 18, 2009, 6:09 a.m.)
Updated based on comment from dimas.
Ship it!
Posted (March 19, 2009, 4:32 a.m.)

   

  
/branches/1.6.0/channels/chan_sip.c (Diff revision 2)
 
 
As a general note, take care when porting to trunk and 1.6.1, as the scheduler entries must take into account reference count handling.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.