Review Board 1.7.16


Abstract Jitter Buffer API Unit Tests

Review Request #2035 - Created July 12, 2012 and submitted

Matt Jordan
trunk
Reviewers
asterisk-dev
mmichelson
Asterisk
This patch pulls over the unit test from the now defunct DTMF jitter buffer patch.  It includes the following:

* Tweaks to the abstract_jb API to remove the unnecessary resync_threshold parameter from the create function (resync_threshold is already in the struct passed into the create function)
* Ensure the fixed jitter buffer is empty before destroying it, to avoid an ASSERT
* Don't "resync" the adaptive jitter buffer.  The mechanism that was being used actually causes the jitter buffer to think its being overflowed by going around the jitterbuf API and attempting to 'resynch' it improperly.  If a resync is needed, the jitter buffer will do it properly by itself.  Note that this is only an optimization needed for trunk, as the worst that happens is the loss of three voice packets before the adaptive jitter buffer will resync anyway (but it does cause the unit tests to fail, as the first packet in gets treated as an overflow).

This pulls over the unit tests for the abstract_jb, removing the DTMF portions.

 
Posted (July 13, 2012, 5:56 a.m.)

   

  
/trunk/tests/test_abstract_jb.c (Diff revision 1)
 
 
This test needs a new name.
  1. Fixed before commit!
Ship it!
Posted (July 23, 2012, 10:01 a.m.)

   

  

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.