Review Board 1.7.16

LDAP Realtime Peers Cannot Register

Review Request #2095 - Created Sept. 4, 2012 and submitted

Darren Sessions
"Prior to 1.8, it was not necessary for an explicit "type" to be set for an asterisk LDAP realtime peer. Now the routine find_peer actually checks the type field during registration and fails to find the peer if it is not set.

The attached patch makes a realtime peer be "type=peer" if it is still type 0 upon return from routine build_peer."
Compiled a clean copy of trunk to replicate the issue and then applied the patch and observed the correct (and intended) behavior.
Review request changed
Updated (Sept. 4, 2012, 10:38 a.m.)
Ship it!
Posted (Sept. 4, 2012, 11:52 a.m.)
The patch doesn't actually do what the description says. The type will be whatever type is being searched for, not necessarily a peer type. But still, this fixes the issue as far as I can see. runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to