Review Board 1.7.16


SIP state notify reorganization

Review Request #224 - Created April 15, 2009 and submitted

David Vossel
Reviewers
asterisk-dev
Asterisk
What I've done here is simply break up how a state NOTIFY is built.  It looks like a complicated diff but its really not.  Originally both the XML and sip header information were built within the same function.  While this does work, it does not allow for the creation of multipart/related message bodies that can contain multiple XML entries with only one sip header.  Now a separate function builds the XML for each notify.  This patch also makes maintaining and modifying state notifications in the future much less of a pain. 
tested presence notifications with polycom 650.  everything works as expected. 
Ship it!
Posted (April 16, 2009, 8:29 a.m.)

   

  
/trunk/channels/chan_sip.c (Diff revision 1)
 
 
doxygenify
/trunk/channels/chan_sip.c (Diff revision 1)
 
 
constify mto and mfrom
/trunk/channels/chan_sip.c (Diff revision 1)
 
 
 
 
These can be const

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.