Review Board 1.7.16


Integrate DAHDIScan into chanspy

Review Request #227 - Created April 20, 2009 and submitted

David Vossel
Reviewers
asterisk-dev
russell
Asterisk
DAHDIScan is holding up the astobj2 branch.  This patch moves DAHDIScan into app_chanspy to use chanspy's common_exec logic.

The original plan was to call chanspy within DAHDIScan.  In order not to break DAHDIScan's expected behavior, this requires two new features to be added into chanspy.  One for setting custom DTMF for cycling the next available channel, and another for setting custom DTMF for exiting.  As it turns out, this was not enough to guarantee DAHDIScan will work as it used to and DAHDIScan had to be integrated within chanspy (which really makes more sense to begin with, why should one app have to depend on another app).  So, there are some new features added into chanspy and extenspy that don't have to be there, but they're already written and shouldn't break anything.  The underling logic for these features will remain regardless if the user can set them or not, so I really don't see any reason not to include them. 
tested DAHDIScan, with and without groups, works as expected. 
Ship it!
Posted (April 20, 2009, 9:45 a.m.)
Nice work, David!

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.