Review Board 1.7.16


Segfault when switching upd to tcp in sip.conf after reload

Review Request #229 - Created April 21, 2009 and submitted

David Vossel
14727
Reviewers
asterisk-dev
Asterisk
If transport in sip.conf is switched from upd to tcp, Asterisk segfaults right after issuing a sip reload.  The problem is the socket type is changed to TCP but the fd may still be present for UDP.  Later, when the tcp session should be created or set using an existing one, it isn't because the old file descriptor is still present.  Now every time transport is changed during a sip.conf reload, the file descriptor is set to -1, signifying it must be created or found.
switched between tcp and udp, upd to tcp, did reloads, no problems. 
Review request changed
Updated (April 21, 2009, 7:36 a.m.)
  • changed from to Segfault when switching upd to tcp in sip.conf after reload
Ship it!
Posted (April 21, 2009, 7:52 a.m.)
Looks good, thanks David

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.