New signaling module to handle analog operations in chan_dahdi
Review Request #253 - Created May 22, 2009 and submitted
This branch splits all the analog signaling logic out of chan_dahdi.c into sig_analog.c. Functionality in theory should not change at all.
The main testing I did was simply making calls. Once I got that working most everything else seemed to work. Specifically made sure caller id works for both sending and receiving as well.
Posted (May 22, 2009, 9:44 a.m.)
Posted (May 29, 2009, 6:12 a.m.)
I pointed out a few formatting things in new/modified code. Check for and fix other places with trailing whitespace or switch/case not aligned properly. Also, we discussed IRL yesterday about adding some comments to places where commented out code is left in. Please leave a note that explains why it is being left there so that someone else doesn't come behind you and remove it. This code could certainly use some documentation love, but in this case, I'm okay with it going in without it for now.