Review Board 1.7.16

New signaling module to handle analog operations in chan_dahdi

Review Request #253 - Created May 22, 2009 and submitted

Jeff Peeler
This branch splits all the analog signaling logic out of chan_dahdi.c into sig_analog.c. Functionality in theory should not change at all.
The main testing I did was simply making calls. Once I got that working most everything else seemed to work. Specifically made sure caller id works for both sending and receiving as well.
Review request changed
Updated (May 26, 2009, 7:58 a.m.)
Fixed a problem with three way calling. Changed linking for sig_analog.o and updated the copyright headers. 
Ship it!
Posted (May 29, 2009, 6:12 a.m.)
I pointed out a few formatting things in new/modified code.  Check for and fix other places with trailing whitespace or switch/case not aligned properly.

Also, we discussed IRL yesterday about adding some comments to places where commented out code is left in.  Please leave a note that explains why it is being left there so that someone else doesn't come behind you and remove it.

This code could certainly use some documentation love, but in this case, I'm okay with it going in without it for now.
/trunk/channels/chan_dahdi.c (Diff revision 2)
minor whitespace issue
/trunk/channels/chan_dahdi.c (Diff revision 2)
Align case and switch
/trunk/channels/sig_analog.h (Diff revision 2)
Don't forget to fix these copyright headers to match the others in Asterisk.  I think you may have actually already done this in the branch ...
/trunk/channels/sig_analog.c (Diff revision 2)
Align case and switch runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to