Review Board 1.7.16

Abstract tech_pvt for chan_pjsip channels

Review Request #2674 - Created July 15, 2013 and submitted

Joshua Colp
chan_pjsip currently places its own structure within the tech_pvt of channels. This allows it to store additional information (like an array for quick media session lookups) but also means that given a channel it is not possible to get the session when you know it is a chan_pjsip channel. This is extremely useful for things like frame hooks and allows things to extend behavior and functionality easier.

The attached patch abstracts the tech_pvt for chan_pjsip channels a bit by having a defined structure which contains the implementation details and also the session itself. Since the structure is defined as part of res_sip_session modules can use it to get the session when need be.

I called the structure ast_sip_channel as I couldn't come up with anything else, but if you take offense to the name suggest a new one and it will be changed.
Placed calls, confirmed sane.
Review request changed
Updated (July 23, 2013, 8:22 a.m.)
  • changed from pending to submitted
Committed in revision 395117 runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to