Review Board 1.7.16


Fix bridge/channel AMI event ordering issues

Review Request #2677 - Created July 15, 2013 and submitted

David Lee
/trunk
ASTERISK-22038
Reviewers
asterisk-dev
Asterisk
The stasis_cache_update messages are somewhat cumbersome to handle
with the stasis_message_router. Since all updates have the same
message type, they are normally handled with the same route.

Since caching itself is a first class component of stasis-core, it
makes sense for the router to handle the cache update messages itself.
This patch adds stasis_message_router_add_cache_update() and
stasis_message_router_remove_cache_update() to handle the routing of
stasis_cache_update messages.

This patch also corrects an issue with manager_{bridging,channels}.c,
where events might be reordered. The reordering occurs because the
components use different message routers, which they needed because
they both needed to route cache update messages. They now both use
manager's router, and add cache routes for just the cache updates they
are interested in.
Unit tests! 

Note that https://reviewboard.asterisk.org/r/2675/ is required to fix
assertions during the test.
Review request changed
Updated (July 23, 2013, 9:22 a.m.)
  • changed from pending to submitted
Committed in revision 395133

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.