Review Board 1.7.16


Verbose logging discrepancies

Review Request #2798 - Created Aug. 27, 2013 and submitted

Kevin Harwell
11
AST-1193
Reviewers
asterisk-dev
Asterisk
Refactored cases where a combination of ast_verbose/options_verbose were present.  Also in general tried to eliminate, in as many places as possible, where the options_verbose global variable was being used.  Refactored the way local and remote consoles handle verbose message logging in an attempt to solve the various discrepancies that sometimes would show between the two.
Tested several logging scenarios with various combinations of levels, messages, and consoles.  Also made sure the app_verbose and dumpchan were still working as expected after the changes.

Changes between revision 1 and 2

1 2
1 2

  1. branches/11/channels/chan_misdn.c: Loading...
  2. branches/11/main/asterisk.c: Loading...
  3. branches/11/main/features.c: Loading...
branches/11/channels/chan_misdn.c
Revision 397483 New Change
[20] 10200 lines
[+20] [+] cb_events(enum event_e event, struct misdn_bchannel *bc, void *user_data)
10201

    
   
10201

   
10202
		{
10202
		{
10203
			struct ast_format_cap *cap = ast_format_cap_alloc_nolock();
10203
			struct ast_format_cap *cap = ast_format_cap_alloc_nolock();
10204
			struct ast_format tmpfmt;
10204
			struct ast_format tmpfmt;
10205
			if (!(cap)) {
10205
			if (!(cap)) {
10206
				return RESPONSE_ERR; 
10206
				return RESPONSE_ERR;
10207
			}
10207
			}
10208
			ast_format_cap_add(cap, ast_format_set(&tmpfmt, AST_FORMAT_ALAW, 0));
10208
			ast_format_cap_add(cap, ast_format_set(&tmpfmt, AST_FORMAT_ALAW, 0));
10209
			chan = misdn_new(ch, AST_STATE_RESERVED, bc->dialed.number, bc->caller.number, cap, NULL, bc->port, bc->channel);
10209
			chan = misdn_new(ch, AST_STATE_RESERVED, bc->dialed.number, bc->caller.number, cap, NULL, bc->port, bc->channel);
10210
			cap = ast_format_cap_destroy(cap);
10210
			cap = ast_format_cap_destroy(cap);
10211
		}
10211
		}
[+20] [20] 1018 lines
[+20] [+] static struct ast_custom_function misdn_cc_function = {
11230

    
   
11230

   
11231

    
   
11231

   
11232
static int unload_module(void)
11232
static int unload_module(void)
11233
{
11233
{
11234
	/* First, take us out of the channel loop */
11234
	/* First, take us out of the channel loop */
11235
	ast_log(LOG_VERBOSE, "-- Unregistering mISDN Channel Driver --\n");
11235
	ast_verb(0, "-- Unregistering mISDN Channel Driver --\n");
11236

    
   
11236

   
11237
	misdn_tasks_destroy();
11237
	misdn_tasks_destroy();
11238

    
   
11238

   
11239
	if (!g_config_initialized) {
11239
	if (!g_config_initialized) {
11240
		return 0;
11240
		return 0;
[+20] [20] 1568 lines
branches/11/main/asterisk.c
Diff Revision 1 Diff Revision 2
 
branches/11/main/features.c
Diff Revision 1 Diff Revision 2
 
  1. branches/11/channels/chan_misdn.c: Loading...
  2. branches/11/main/asterisk.c: Loading...
  3. branches/11/main/features.c: Loading...

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.