Review Board 1.7.16


Pre-review of work to handle SRTP lifetime and MKI in a less bad way, but not the best way

Review Request #2872 - Created April 11, 2014 and updated

Olle E Johansson
1.8
ASTERISK-17899
Reviewers
asterisk-dev
mattjordan
Asterisk
Asterisk 1.8 and later currently just refuse calls that have an SDP lifetime parameter, even if it's ridiculously high. This patch adds a treshold of 10 hours (that could be made configurable) and refuse calls with a shorter lifetime. It also parses MKI/Lifetime properly.

This is not ready for commit anywhere, but I wanted to know if we can agree that this is a good path moving forward. 
I've sent all kind of weird SDES keys from the README.lingon and while it failed previously it now succeeds where I want to and fail when I want it to fail.
Posted (April 15, 2014, 9:24 a.m.)
I don't see a diff attached to this review. Did post-review hiccup on you? :-)
  1. Something must have happened. Well, the patch is a secret then... It's in the lingon branch, I'll upload it when back in the office. 

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.