Review Board 1.7.16


Performance: Taskprocessor optimization; switch Stasis to use taskprocessors

Review Request #2881 - Created Sept. 25, 2013 and submitted

David Lee
/team/dlee/taskprocessor-optimization
Reviewers
asterisk-dev
Asterisk
This patch optimizes taskprocessor to use a semaphore for signaling,
which the OS can do a better job at managing contention and waiting
that we can with a mutex and condition.

The taskprocessor execution was also slightly optimized to reduce the
number of locks taken.

The only observable difference in the taskprocessor implementation is
that when the final reference to the taskprocessor goes away, it will
execute all tasks to completion instead of discarding the unexecuted
tasks.

For systems where unnamed semaphores are not supported, a really
simple semaphore implementation is provided. (Which gives identical
performance as the original taskprocessor implementation).

The way we ended up implementing Stasis caused the threadpool to be a
burden instead of a boost to performance. This was switched to just
use taskprocessors directly for subscriptions.
Unit tests pass.

Same performance test as from https://reviewboard.asterisk.org/r/2873/
Review request changed
Updated (Dec. 1, 2014, 12:26 p.m.)
  • changed from pending to submitted
Committed in revision 428707

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.