Review Board 1.7.16


Update /channels/:id/play documentation and variables

Review Request #2937 - Created Oct. 18, 2013 and updated

Paul Belanger
trunk
Reviewers
asterisk-dev
Asterisk
Update documentation to avoid some confusing that I had.  I also drop ms from offset and skip, there not camelCase and unneeded IMO.
python-ari and swagger
Total:
1
Open:
1
Resolved:
0
Dropped:
0
Status:
From:
Description From Last Updated Status
Don't mention "audio" here since playback can be used for other media types. Mark Michelson Oct. 21, 2013, 11:39 a.m. Open
Posted (Oct. 21, 2013, 11:39 a.m.)
In general, I think that the removal of the "ms" everywhere is a bad idea. Any time that a variable/parameter/etc. has the benefit of being self-documenting, that's a good thing. Removal of "ms" is a step backwards. A parameter called "skip" is much less suggestive of its use instead of "skipms/skip_ms/skipMS/etc." 
trunk/rest-api/api-docs/channels.json (Diff revision 1)
 
 
 
Don't mention "audio" here since playback can be used for other media types.
trunk/rest-api/api-docs/channels.json (Diff revision 1)
 
 
 
Just my opinion, but I think the previous wording is better.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.