Review Board 1.7.16


ARI: User better nicknames for ARI operations

Review Request #2940 - Created Oct. 18, 2013 and submitted

David Lee
/team/dlee/better-nicknames
Reviewers
asterisk-dev
Asterisk
While working on building client libraries from the Swagger API, I
noticed a problem with the nicknames.

    channel.deleteChannel()
    channel.answerChannel()
    channel.muteChannel()

Etc. We put the object name in the nickname (since we were generating C
code), but it makes OO generators redundant.

This patch makes the nicknames more OO friendly. This resulted in a lot
of name changing within the res_ari_*.so modules, but not much else.

There were a couple of other fixed I made in the process.

 * When reversible operations (POST /hold, POST /unhold) were made more
   RESTful (POST /hold, DELETE /unhold), the path for the second operation
   was left in the API declaration. This worked, but really the two
   operations should have been on the same API.
 * The POST /unmute operation had still not been REST-ified.
Hit each ARI resource to ensure it still responded.
Total:
10
Open:
0
Resolved:
4
Dropped:
6
Status:
From:
Review request changed
Updated (Nov. 7, 2013, 3:21 p.m.)
  • changed from pending to submitted
Committed in revision 402536

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.