Review Board 1.7.16


Return 409 if trying to remove a channel (in Playback) from a bridge

Review Request #2943 - Created Oct. 18, 2013 and updated

Paul Belanger
trunk
Reviewers
asterisk-dev
Asterisk
Ran into a blocking issue, if you try to remove a channel from a bridge while playback's are queue, the HTTP request will block.  Now we return 409 listing which channel is the issue.
Local development box / swagger
Total:
2
Open:
2
Resolved:
0
Dropped:
0
Status:
From:
Posted (Oct. 31, 2013, 2:22 p.m.)
What might be a preferable solution would be to change
stasis_app_control_remove_channel_from_bridge() to be asynchronous.
We're ignoring the return code anyways, and by pre-checking that the
channel is indeed in the bridge the only failures removing the channel
from the bridge would be internal to Asterisk, and you'll find
yourself digging through the log trying to figure out what went wrong
anyways.
trunk/res/ari/resource_bridges.c (Diff revision 1)
 
 
 
There's a possible race condition here. Between the time that you
check, and when you call the remove code below a playback could be
started.
trunk/res/ari/resource_bridges.c (Diff revision 1)
 
 
 
 
We're responding with JSON, the channel id ought to be its own field
instead (or maybe in addition to) being embedded in the message
string.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.