Review Board 1.7.16


Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

Review Request #3072 - Created Dec. 13, 2013 and submitted

rmudgett
12
Reviewers
asterisk-dev
Asterisk
Removed code from the system for normal mailbox handling that appends @default to the mailbox identifier if it does not have a context.  The only exception is the legacy hasvoicemail users.conf option.  The legacy option will only work for app_voicemail mailboxes.  (I'd like to just remove the hasvoicemail option since it is usually superceeded by an explicit mailbox option. :) )  The system cannot make any assumptions about the format of the mailbox identifer used by app_voicemail.

chan_sip and chan_dahdi/sig_pri had the most changes because they both tried to interpret the mailbox identifier.  chan_sip just stored and compared the two components.  chan_dahdi actually used the box information.

The ISDN MWI support configuration options had to be reworked because chan_dahdi was parsing the box@context format to get the box number.  As a result the mwi_vm_boxes chan_dahdi.conf option was added and is documented in the chan_dahdi.conf.sample file.
Tested chan_dahdi to be sure that the new mwi_vm_boxes option parses correctly and sets up mailboxes.
Tested chan_sip to be sure that the mailbox option works.
/branches/12/CHANGES
Diff Revision 1 Diff Revision 3
[20] 972 lines
[+20]
973
SPEECH_ENGINE
973
SPEECH_ENGINE
974
------------------
974
------------------
975
 * The SPEECH_ENGINE function now supports read operations. When read from, it
975
 * The SPEECH_ENGINE function now supports read operations. When read from, it
976
   will return the current value of the requested attribute.
976
   will return the current value of the requested attribute.
977

    
   
977

   

    
   
978
VMCOUNT:

    
   
979
------------------

    
   
980
 * Mailboxes defined by app_voicemail MUST be referenced by the rest of the

    
   
981
   system as mailbox@context.  The rest of the system cannot add @default

    
   
982
   to mailbox identifiers for app_voicemail that do not specify a context

    
   
983
   any longer.  It is a mailbox identifier format that should only be

    
   
984
   interpreted by app_voicemail.

    
   
985

   
978

    
   
986

   
979
Resources
987
Resources
980
------------------
988
------------------
981

    
   
989

   
982
res_agi (Asterisk Gateway Interface)
990
res_agi (Asterisk Gateway Interface)
[+20] [20] 2812 lines
/branches/12/UPGRADE.txt
Diff Revision 1 Diff Revision 3
 
/branches/12/apps/app_voicemail.c
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/chan_dahdi.h
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/chan_dahdi.c
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/chan_h323.c
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/chan_iax2.c
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/chan_mgcp.c
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/chan_sip.c
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/chan_skinny.c
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/chan_unistim.c
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/sig_pri.h
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/sig_pri.c
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/h323/chan_h323.h
Diff Revision 1 Diff Revision 3
 
/branches/12/channels/sip/include/sip.h
Diff Revision 1 Diff Revision 3
 
/branches/12/configs/chan_dahdi.conf.sample
Diff Revision 1 Diff Revision 3
 
/branches/12/configs/iax.conf.sample
Diff Revision 1 Diff Revision 3
 
/branches/12/configs/sip.conf.sample
Diff Revision 1 Diff Revision 3
 
/branches/12/configs/skinny.conf.sample
Diff Revision 1 Diff Revision 3
 
/branches/12/configs/voicemail.conf.sample
Diff Revision 1 Diff Revision 3
 
/branches/12/funcs/func_vmcount.c
Diff Revision 1 Diff Revision 3
 
/branches/12/include/asterisk/app.h
Diff Revision 1 Diff Revision 3
 
/branches/12/main/app.c
Diff Revision 1 Diff Revision 3
 
/branches/12/res/res_jabber.c
Diff Revision 1 Diff Revision 3
 
/branches/12/res/res_xmpp.c
Diff Revision 1 Diff Revision 3
 
  1. /branches/12/CHANGES: Loading...
  2. /branches/12/UPGRADE.txt: Loading...
  3. /branches/12/apps/app_voicemail.c: Loading...
  4. /branches/12/channels/chan_dahdi.h: Loading...
  5. /branches/12/channels/chan_dahdi.c: Loading...
  6. /branches/12/channels/chan_h323.c: Loading...
  7. /branches/12/channels/chan_iax2.c: Loading...
  8. /branches/12/channels/chan_mgcp.c: Loading...
  9. /branches/12/channels/chan_sip.c: Loading...
  10. /branches/12/channels/chan_skinny.c: Loading...
  11. /branches/12/channels/chan_unistim.c: Loading...
  12. /branches/12/channels/sig_pri.h: Loading...
  13. /branches/12/channels/sig_pri.c: Loading...
  14. /branches/12/channels/h323/chan_h323.h: Loading...
  15. /branches/12/channels/sip/include/sip.h: Loading...
  16. /branches/12/configs/chan_dahdi.conf.sample: Loading...
  17. /branches/12/configs/iax.conf.sample: Loading...
  18. /branches/12/configs/sip.conf.sample: Loading...
  19. /branches/12/configs/skinny.conf.sample: Loading...
  20. /branches/12/configs/voicemail.conf.sample: Loading...
  21. /branches/12/funcs/func_vmcount.c: Loading...
  22. /branches/12/include/asterisk/app.h: Loading...
  23. /branches/12/main/app.c: Loading...
  24. /branches/12/res/res_jabber.c: Loading...
  25. /branches/12/res/res_xmpp.c: Loading...

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.