Review Board 1.7.16


Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

Review Request #3072 - Created Dec. 13, 2013 and submitted

rmudgett
12
Reviewers
asterisk-dev
Asterisk
Removed code from the system for normal mailbox handling that appends @default to the mailbox identifier if it does not have a context.  The only exception is the legacy hasvoicemail users.conf option.  The legacy option will only work for app_voicemail mailboxes.  (I'd like to just remove the hasvoicemail option since it is usually superceeded by an explicit mailbox option. :) )  The system cannot make any assumptions about the format of the mailbox identifer used by app_voicemail.

chan_sip and chan_dahdi/sig_pri had the most changes because they both tried to interpret the mailbox identifier.  chan_sip just stored and compared the two components.  chan_dahdi actually used the box information.

The ISDN MWI support configuration options had to be reworked because chan_dahdi was parsing the box@context format to get the box number.  As a result the mwi_vm_boxes chan_dahdi.conf option was added and is documented in the chan_dahdi.conf.sample file.
Tested chan_dahdi to be sure that the new mwi_vm_boxes option parses correctly and sets up mailboxes.
Tested chan_sip to be sure that the mailbox option works.
/branches/12/CHANGES
Revision 403807 New Change
[20] 334 lines
[+20]
335
 * In addition to AMI, UserEvent invocations will now be distributed to any
335
 * In addition to AMI, UserEvent invocations will now be distributed to any
336
   interested Stasis applications.
336
   interested Stasis applications.
337

    
   
337

   
338
VoiceMail
338
VoiceMail
339
------------------
339
------------------

    
   
340
 * Mailboxes defined by app_voicemail MUST be referenced by the rest of the

    
   
341
   system as mailbox@context.  The rest of the system cannot add @default

    
   
342
   to mailbox identifiers for app_voicemail that do not specify a context

    
   
343
   any longer.  It is a mailbox identifier format that should only be

    
   
344
   interpreted by app_voicemail.

    
   
345

   
340
 * The voicemail.conf configuration file now has an 'alias' configuration
346
 * The voicemail.conf configuration file now has an 'alias' configuration
341
   parameter for use with the Directory application. The voicemail realtime
347
   parameter for use with the Directory application. The voicemail realtime
342
   database table schema has also been updated with an 'alias' column.
348
   database table schema has also been updated with an 'alias' column.
343

    
   
349

   
344

    
   
350

   
[+20] [20] 474 lines
[+20]
819

    
   
825

   
820
 * Added the CLI command 'dahdi create channels'. A range of channels can be
826
 * Added the CLI command 'dahdi create channels'. A range of channels can be
821
   specified to be created, or the keyword 'new' can be used to add channels
827
   specified to be created, or the keyword 'new' can be used to add channels
822
   not yet created.
828
   not yet created.
823

    
   
829

   

    
   
830
 * Added mwi_vm_boxes that also must be configured for ISDN MWI to be enabled.

    
   
831

   
824
chan_iax2
832
chan_iax2
825
------------------
833
------------------
826
 * IPv6 support has been added.  We are now able to bind to and
834
 * IPv6 support has been added.  We are now able to bind to and
827
   communicate using IPv6 addresses.
835
   communicate using IPv6 addresses.
828

    
   
836

   
[+20] [20] 2958 lines
/branches/12/UPGRADE.txt
Revision 403807 New Change
 
/branches/12/apps/app_voicemail.c
Revision 403807 New Change
 
/branches/12/channels/chan_dahdi.c
Revision 403807 New Change
 
/branches/12/channels/chan_h323.c
Revision 403807 New Change
 
/branches/12/channels/chan_iax2.c
Revision 403807 New Change
 
/branches/12/channels/chan_mgcp.c
Revision 403807 New Change
 
/branches/12/channels/chan_sip.c
Revision 403807 New Change
 
/branches/12/channels/chan_skinny.c
Revision 403807 New Change
 
/branches/12/channels/chan_unistim.c
Revision 403807 New Change
 
/branches/12/channels/sig_pri.h
Revision 403807 New Change
 
/branches/12/channels/sig_pri.c
Revision 403807 New Change
 
/branches/12/channels/sip/include/sip.h
Revision 403807 New Change
 
/branches/12/configs/chan_dahdi.conf.sample
Revision 403807 New Change
 
/branches/12/configs/iax.conf.sample
Revision 403807 New Change
 
/branches/12/configs/sip.conf.sample
Revision 403807 New Change
 
/branches/12/configs/skinny.conf.sample
Revision 403807 New Change
 
/branches/12/configs/voicemail.conf.sample
Revision 403807 New Change
 
/branches/12/funcs/func_vmcount.c
Revision 403807 New Change
 
/branches/12/include/asterisk/app.h
Revision 403807 New Change
 
/branches/12/main/app.c
Revision 403807 New Change
 
/branches/12/res/res_jabber.c
Revision 403807 New Change
 
/branches/12/res/res_xmpp.c
Revision 403807 New Change
 
  1. /branches/12/CHANGES: Loading...
  2. /branches/12/UPGRADE.txt: Loading...
  3. /branches/12/apps/app_voicemail.c: Loading...
  4. /branches/12/channels/chan_dahdi.c: Loading...
  5. /branches/12/channels/chan_h323.c: Loading...
  6. /branches/12/channels/chan_iax2.c: Loading...
  7. /branches/12/channels/chan_mgcp.c: Loading...
  8. /branches/12/channels/chan_sip.c: Loading...
  9. /branches/12/channels/chan_skinny.c: Loading...
  10. /branches/12/channels/chan_unistim.c: Loading...
  11. /branches/12/channels/sig_pri.h: Loading...
  12. /branches/12/channels/sig_pri.c: Loading...
  13. /branches/12/channels/sip/include/sip.h: Loading...
  14. /branches/12/configs/chan_dahdi.conf.sample: Loading...
  15. /branches/12/configs/iax.conf.sample: Loading...
  16. /branches/12/configs/sip.conf.sample: Loading...
  17. /branches/12/configs/skinny.conf.sample: Loading...
  18. /branches/12/configs/voicemail.conf.sample: Loading...
  19. /branches/12/funcs/func_vmcount.c: Loading...
  20. /branches/12/include/asterisk/app.h: Loading...
  21. /branches/12/main/app.c: Loading...
  22. /branches/12/res/res_jabber.c: Loading...
  23. /branches/12/res/res_xmpp.c: Loading...

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.