Review Board 1.7.16


verbosity: Fix performance of console verbose messages.

Review Request #3114 - Created Jan. 9, 2014 and submitted

rmudgett
11
AST-1252
Reviewers
asterisk-dev
Asterisk
The per console verbose level feature as previously implemented caused a large performance penalty.  The fix required some minor incompatibilities if the new rasterisk is used to connect to an earlier version.  If the new rasterisk connects to an older Asterisk version then the root console verbose level is always affected by the "core set verbose" command of the remote console even though it may appear to only affect the current console.  If an older version of rasterisk connects to the new version then the "core set verbose" command will have no effect.

* Fixed the verbose performance by not generating a verbose message if nothing is going to use it and then filtered any generated verbose messages before actually sending them to the remote consoles.

* Split the "core set debug" and "core set verbose" CLI commands to remove the per module verbose support that cannot work with the per console verbose level.

* Added a silent option to the "core set verbose" command.

* Fixed "core set debug off" tab completion.

* Made "core show settings" list the current console verbosity in addition to the root console verbosity.

* Changed the default verbose level of the 'verbose' setting in the logger.conf [logfiles] section.  The default is now to once again follow the current root console level.  As a result, using the AMI Command action with "core set verbose" could again set the root console verbose level and affect the verbose level logged.
Setup an extension that had a simple dialplan extension that decremented a counter from 500000 and nothing logging or viewing verbose messages.
On my machine, Asterisk v11 without the patch took 63 seconds while with the patch it took 25 seconds.

Tested the "core set verbose" CLI command tab completion.

Tested that different verbose levels on multiple rasterisk connections got the expected verbose messages.
/branches/11/UPGRADE.txt
Revision 405296 New Change
[20] 17 lines
[+20]
18
=== UPGRADE-1.8.txt -- Upgrade info for 1.6 to 1.8
18
=== UPGRADE-1.8.txt -- Upgrade info for 1.6 to 1.8
19
=== UPGRADE-10.txt -- Upgrade info for 1.8 to 10
19
=== UPGRADE-10.txt -- Upgrade info for 1.8 to 10
20
===
20
===
21
===========================================================
21
===========================================================
22

    
   
22

   

    
   
23
From 11.7 to 11.8:

    
   
24
* The per console verbose level feature as previously implemented caused a

    
   
25
  large performance penalty.  The fix required some minor incompatibilities

    
   
26
  if the new rasterisk is used to connect to an earlier version.  If the new

    
   
27
  rasterisk connects to an older Asterisk version then the root console verbose

    
   
28
  level is always affected by the "core set verbose" command of the remote

    
   
29
  console even though it may appear to only affect the current console.  If

    
   
30
  an older version of rasterisk connects to the new version then the

    
   
31
  "core set verbose" command will have no effect.

    
   
32

   

    
   
33
CLI commands:

    
   
34
 - "core show settings" now lists the current console verbosity in addition

    
   
35
   to the root console verbosity.

    
   
36

   

    
   
37
 - "core set verbose" has not been able to support the by module verbose

    
   
38
   logging levels since verbose logging levels were made per console.  That

    
   
39
   syntax is now removed and a silence option added in its place.

    
   
40

   

    
   
41
Configuration Files:

    
   
42
 - The 'verbose' setting in logger.conf still takes an optional argument,

    
   
43
   specifying the verbosity level for each logging destination.  However,

    
   
44
   the default is now to once again follow the current root console level.

    
   
45
   As a result, using the AMI Command action with "core set verbose" could

    
   
46
   again set the root console verbose level and affect the verbose level

    
   
47
   logged.

    
   
48

   
23
From 11.6 to 11.7:
49
From 11.6 to 11.7:
24
ConfBridge
50
ConfBridge
25
 - ConfBridge now has the ability to set the language of announcements to the
51
 - ConfBridge now has the ability to set the language of announcements to the
26
   conference.  The language can be set on a bridge profile in confbridge.conf
52
   conference.  The language can be set on a bridge profile in confbridge.conf
27
   or by the dialplan function CONFBRIDGE(bridge,language)=en.
53
   or by the dialplan function CONFBRIDGE(bridge,language)=en.
[+20] [20] 301 lines
/branches/11/apps/app_dumpchan.c
Revision 405296 New Change
 
/branches/11/apps/app_verbose.c
Revision 405296 New Change
 
/branches/11/configs/logger.conf.sample
Revision 405296 New Change
 
/branches/11/funcs/func_timeout.c
Revision 405296 New Change
 
/branches/11/include/asterisk/logger.h
Revision 405296 New Change
 
/branches/11/main/asterisk.c
Revision 405296 New Change
 
/branches/11/main/cli.c
Revision 405296 New Change
 
/branches/11/main/logger.c
Revision 405296 New Change
 
/branches/11/main/manager.c
Revision 405296 New Change
 
/branches/11/main/pbx.c
Revision 405296 New Change
 
  1. /branches/11/UPGRADE.txt: Loading...
  2. /branches/11/apps/app_dumpchan.c: Loading...
  3. /branches/11/apps/app_verbose.c: Loading...
  4. /branches/11/configs/logger.conf.sample: Loading...
  5. /branches/11/funcs/func_timeout.c: Loading...
  6. /branches/11/include/asterisk/logger.h: Loading...
  7. /branches/11/main/asterisk.c: Loading...
  8. /branches/11/main/cli.c: Loading...
  9. /branches/11/main/logger.c: Loading...
  10. /branches/11/main/manager.c: Loading...
  11. /branches/11/main/pbx.c: Loading...

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.