Review Board 1.7.16


Iterate through logger.conf [general] section

Review Request #3279 - Created Feb. 27, 2014 and updated

Paul Belanger
trunk
Reviewers
asterisk-dev
Asterisk
This patch allows you to override the [general] section of logger.conf, making it the same functionality as the [logfiles] sections.
local development. Setup

[general]
queue_log = no
queue_log = yes

Queue logfiles were created.
Review request changed
Updated (Feb. 28, 2014, 10:34 a.m.)
Posted (March 3, 2014, 12:47 p.m.)
So, what is needed to get this into 1.8, 11 as it stands now?  I'll be trying to use the new config framework and see if I can get it going.
  1. Improvements that do not fix bugs are generally not made in the existing release branches - particularly for LTS releases. 12 had a very different policy from the very beginning, which was communicated ad nauseum.
    
    Sometimes, in extremely rare cases, improvements have been allowed in the existing release branches. Generally, this has occurred when there is little to no risk of it affecting existing systems.
    
    This patch actually is a behavioural change. If someone had two identical configuration parameters in logger.conf, it changes the preference from the first parameter to the last. While that may be preferable, it does introduce the possibility of an existing system no longer working mid-stream in an LTS release.
    
    Barring a very convincing argument about how this cannot impact an existing system, and how this improvement will generally make a large number of people's lives better, I don't think this should be a candidate for inclusion in those branches.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.