Review Board 1.7.16


chan_sip: Support a=rtcp attribute in SDP

Review Request #3439 - Created April 11, 2014 and updated

Olle E Johansson
blackberry
Reviewers
asterisk-dev
Asterisk
the A=rtcp attribute in SDP points out a different port than the mediaport+1 to receive RTCP on. This patch adds a new api to rtpengine and res_rtp_asterisk and updates chan_sip to use it.

This patch needs to be modified to handle the IP address argument too.
A massive amount of testing with a test tool for interoperability.
Review request changed
Updated (May 16, 2014, 7:36 a.m.)
  • the A=rtcp attribute in SDP points out a different port than the mediaport+1 to receive RTCP on. This patch adds a new api to rtpengine and res_rtp_asterisk and updates chan_sip to use it.

    the A=rtcp attribute in SDP points out a different port than the mediaport+1 to receive RTCP on. This patch adds a new api to rtpengine and res_rtp_asterisk and updates chan_sip to use it.
    
    This patch needs to be modified to handle the IP address argument too.
Adding a few comments. The patch works as is with many implementations, but lacks support of the IP address argument if that's used.
Posted (May 16, 2014, 8:03 a.m.)

   

  
/trunk/res/res_rtp_asterisk.c (Diff revision 1)
 
 
Should this be an 'else if?'  If not it should be on its own line.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.