Review Board 1.7.16


Prevent a queue member's state from getting stuck when using dynamic hints as 'state_interface'

Review Request #3508 - Created April 30, 2014 and updated

sysreq
ASTERISK-18411
Reviewers
asterisk-dev
Asterisk
The rationale behind this patch is that when a hint is used as a 'state_interface', app_queue should explicitly subscribe to it and become a watcher. That will prevent a dynamic hint from disappearing after a 'dialplan reload' because Asterisk thinks it's not being "watched" by anything. We should also unsubscribe from the hint when the agent is removed from the queue.
I have tested this patch by using either a dynamic hint, a static hint, a local channel or a SIP device as a queue member's 'state_interface'. I have also added/removed the queue member both through Realtime and the CLI.

I've had this patch on about half a dozen 1.8/11 production systems (all averaging a thousand users each) for a little more than a month with no apparent issue.
Total:
3
Open:
1
Resolved:
2
Dropped:
0
Status:
From:
Review request changed
Updated (May 2, 2014, 9:52 a.m.)
Posted (May 2, 2014, 11:05 a.m.)

   

  
/branches/11/apps/app_queue.c (Diff revision 2)
 
 
 
 
 
 
 
Annoyingly, I think you'll need to also unsubscribe from the extension here as well.

Since this is slipping the reloaded member back into the same position in the queue, you can't just call member_remove_from_queue here.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.