Review Board 1.7.16


accountcode: Slightly change accountcode propagation.

Review Request #3601 - Created June 6, 2014 and submitted

rmudgett
trunk
AFS-65
Reviewers
asterisk-dev
Asterisk
Accountcode propagation:

The current behavior is to simply set the accountcode of an outgoing
channel to the accountcode of the channel initiating the call.  It was
done this way a long time ago to allow the accountcode set on the SIP/100
channel to be propagated to a local channel so the dialplan execution on
the Local;2 channel would have the SIP/100 accountcode available.

SIP/100 -> Local;1/Local;2 -> SIP/200

Propagating the SIP/100 accountcode to the local channels is very useful.
Without any dialplan manipulation, all channels in this call would have
the same accountcode.

Using dialplan, you can set a different accountcode on the SIP/200 channel
either by setting the accountcode on the Local;2 channel or by the Dial
application's b(pre-dial), M(macro) or U(gosub) options, or by the
FollowMe application's b(pre-dial) option, or by the Queue application's
macro or gosub options.  Before Asterisk v12, the altered accountcode on
SIP/200 will remain until the local channels optimize out and the
accountcode would change to the SIP/100 accountcode.

Asterisk v1.8 attempted to add peeraccount support but ultimately had to
punt on the support.  The peeraccount support was rendered useless because
of how the CDR code needed to unconditionally force the caller's
accountcode onto the peer channel's accountcode.  The CEL events were thus
intentionally made to always use the channel's accountcode as the
peeraccount value.

With the arrival of Asterisk v12, the situation has improved somewhat so
peeraccount support can be made to work.  Using the indicated example, the
the accountcode values become as follows when the peeraccount is set on
SIP/100 before calling SIP/200:

SIP/100 ---> Local;1 ---- Local;2 ---> SIP/200
acct: 100 \/ acct: 200 \/ acct: 100 \/ acct: 200
peer: 200 /\ peer: 100 /\ peer: 200 /\ peer: 100

If a channel already has an accountcode it can only change by the
following explicit user actions:

1) A channel originate method that can specify an accountcode to use.

2) The calling channel propagating its non-empty peeraccount or its
non-empty accountcode if the peeraccount was empty to the outgoing
channel's accountcode before initiating the dial.  e.g., Dial and
FollowMe.  The exception to this propagation method is Queue.  Queue will
only propagate peeraccounts this way only if the outgoing channel does not
have an accountcode.

3) Dialplan using CHANNEL(accountcode).

4) Dialplan using CHANNEL(peeraccount) on the other end of a local
channel pair.

If a channel does not have an accountcode it can get one from the
following places:

1) The channel driver's configuration at channel creation.

2) Explicit user action as already indicated.

3) Entering a basic or stasis-mixing bridge from a peer channel's
peeraccount value.

You can specify the accountcode for an outgoing channel by setting the
CHANNEL(peeraccount) before using the Dial, FollowMe, and Queue
applications.  Queue adds the wrinkle that it will not overwrite an
existing accountcode on the outgoing channel with the calling channels
values.

Accountcode and peeraccount values propagate to an outgoing channel before
dialing.  Accountcodes also propagate when channels enter or leave a basic
or stasis-mixing bridge.  The peeraccount value only makes sense for
mixing bridges with two channels; it is meaningless otherwise.

* Made peeraccount functional by changing accountcode propagation as
described above.

* Fixed CEL extracting the wrong ie value for the peeraccount.  This was
done intentionally in Asterisk v1.8 when that version had to punt on
peeraccount.

* Fixed a few places dealing with accountcodes that were reading from
channels without the lock held.
* Ran tests from https://reviewboard.asterisk.org/r/3832/ all tests tagged
with accountcode pass.

* Set the accountcode on the calling channel and let the channel driver
supply or not the accountcode for the outgoing channel.  The acccountcode
on the calling channel forces itself on the outgoing channel.  This is the
same as previous behavior.

* Set the accountcode and peeraccount code on the calling channel and let
the channel driver supply or not the acccountcode for the outgoing
channel.  The outgoing channel's accountcode and peeraccount got the
calling channel's peeraccount and accountcode values respectively.

* Let dialplan set accountcodes on channels and performed a DTMF attended
transfer to create a three party bridge.  When the transferrer channel
left the three party bridge, the remaining two channels got the
peeraccount updated to the other party.  Unfortunately, you only see the
updated peeraccount values in the CEL log when the channels leave the
bridge.

Throughout each of these tests, the CEL log had the expected peeraccount
value.  Some interpolation is needed in the CEL log for complicated
accountcode manipulation because there aren't enough events to indicate
when the account codes change.  Note the peeraccount value is meaningless
if the bridge does not contain two parties.
/branches/12/UPGRADE.txt
Revision 418248 New Change
[20] 18 lines
[+20]
19
=== UPGRADE-10.txt  -- Upgrade info for 1.8 to 10
19
=== UPGRADE-10.txt  -- Upgrade info for 1.8 to 10
20
=== UPGRADE-11.txt  -- Upgrade info for 10 to 11
20
=== UPGRADE-11.txt  -- Upgrade info for 10 to 11
21
===
21
===
22
===========================================================
22
===========================================================
23

    
   
23

   

    
   
24
From 12.4.0 to 12.5.0:

    
   
25

   

    
   
26
 - Added functional peeraccount support.  Except for Queue, the

    
   
27
   accountcode propagation is now consistently propagated to outgoing

    
   
28
   channels before dialing.  The channel accountcode can change from its

    
   
29
   original non-empty value on channel creation for the following specific

    
   
30
   reasons.  One, dialplan sets it using CHANNEL(accountcode).  Two, an

    
   
31
   originate method that can specify an accountcode value.  Three, the

    
   
32
   calling channel propagates its peeraccount or accountcode to the

    
   
33
   outgoing channel's accountcode before dialing.  The change has two

    
   
34
   visible effects.  One, local channels now cross accountcode and

    
   
35
   peeraccount across the special bridge between the ;1 and ;2 channels

    
   
36
   just like channels between normal bridges.  Two, the

    
   
37
   CHANNEL(peeraccount) value can now be set before Dial and FollowMe to

    
   
38
   set the accountcode on the outgoing channel(s).

    
   
39

   

    
   
40
   For Queue, an outgoing channel's non-empty accountcode will not change

    
   
41
   unless explicitly set by CHANNEL(accountcode).  The change has three

    
   
42
   visible effects.  One, local channels now cross accountcode and

    
   
43
   peeraccount across the special bridge between the ;1 and ;2 channels

    
   
44
   just like channels between normal bridges.  Two, the queue member will

    
   
45
   get an accountcode if it doesn't have one and one is available from the

    
   
46
   calling channel's peeraccount or accountcode.  Three, accountcode

    
   
47
   propagation includes local channel members where the accountcodes are

    
   
48
   propagated early enough to be available on the ;2 channel.

    
   
49

   
24
From 12.3.2 to 12.4.0:
50
From 12.3.2 to 12.4.0:
25

    
   
51

   
26
 - The safe_asterisk script was previously not installed on top of an existing
52
 - The safe_asterisk script was previously not installed on top of an existing
27
   version. This caused bug-fixes in that script not to be deployed. If your
53
   version. This caused bug-fixes in that script not to be deployed. If your
28
   safe_asterisk script is customized, be sure to keep your changes. Custom
54
   safe_asterisk script is customized, be sure to keep your changes. Custom
[+20] [20] 758 lines
/branches/12/apps/app_dial.c
Revision 418248 New Change
 
/branches/12/apps/app_followme.c
Revision 418248 New Change
 
/branches/12/apps/app_queue.c
Revision 418248 New Change
 
/branches/12/include/asterisk/channel.h
Revision 418248 New Change
 
/branches/12/main/bridge.c
Revision 418248 New Change
 
/branches/12/main/bridge_basic.c
Revision 418248 New Change
 
/branches/12/main/cel.c
Revision 418248 New Change
 
/branches/12/main/channel.c
Revision 418248 New Change
 
/branches/12/main/core_unreal.c
Revision 418248 New Change
 
/branches/12/main/dial.c
Revision 418248 New Change
 
/branches/12/main/pbx.c
Revision 418248 New Change
 
/branches/12/res/parking/parking_bridge_features.c
Revision 418248 New Change
 
  1. /branches/12/UPGRADE.txt: Loading...
  2. /branches/12/apps/app_dial.c: Loading...
  3. /branches/12/apps/app_followme.c: Loading...
  4. /branches/12/apps/app_queue.c: Loading...
  5. /branches/12/include/asterisk/channel.h: Loading...
  6. /branches/12/main/bridge.c: Loading...
  7. /branches/12/main/bridge_basic.c: Loading...
  8. /branches/12/main/cel.c: Loading...
  9. /branches/12/main/channel.c: Loading...
  10. /branches/12/main/core_unreal.c: Loading...
  11. /branches/12/main/dial.c: Loading...
  12. /branches/12/main/pbx.c: Loading...
  13. /branches/12/res/parking/parking_bridge_features.c: Loading...

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.