Review Board 1.7.16


App_jack: more than 8Khz

Review Request #3618 - Created June 13, 2014 and submitted

Dennis Guse
trunk
ASTERISK-20696, ASTERISK-23836
Reviewers
asterisk-dev
Asterisk
Target: app_jack.c

Enables the jack-audiohook to cope with dynamic sampling rates from and to Asterisk.
Information from channel is taken to derive the channel's sampling rate, suiting SLINxx format and frame->datalen.

Limitations:
* Required information is taken from channel during initialization as audiohook does not provide this information then. Audiohook.internal_sampl_rate(...) is set later, but no callback is available to inform app_jack.

* Frame.datalen is computed using "rate / 50" assuming a ptime of 20ms.
There is no internal API available to determine datalen for a SLINxx.

* Ringbuffer size is now dynamic depending frame.datalen (see above) and the number of frames, which are in RINGBUFFER_FRAME_CAPACITY, that need to fit.
Checked with jackd and puredata using G.711 and G.722 on Ubuntu 14.0.4 64bit using Linphone and Ekiga.
Total:
5
Open:
0
Resolved:
5
Dropped:
0
Status:
From:
Review request changed
Updated (June 26, 2014, 8:29 a.m.)
  • changed from pending to submitted
Committed in revision 417382

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.