Review Board 1.7.16


when using FEC, asterisk considers negative sequence numbers as missing

Review Request #3657 - Created June 20, 2014 and submitted

Torrey Searle
ASTERISK-23908
Reviewers
asterisk-dev
Asterisk
When using FEC error correction with span=3 and entries=4 asterisk will try to repair in packet with sequence number 5 because it will see that packet -4 is missing. The result is that Asterisk will forward garbage packets that can possibly kill the fax.

This patch adds a check to see if the sequence number is valid before checking if the packet is missing
Replayed the T.38 FEC callflow using a version of SIPP patched to understand m=image for pcapplay
Total:
1
Open:
0
Resolved:
1
Dropped:
0
Status:
From:
Description From Last Updated Status
Review request changed
Updated (June 26, 2014, 8:27 a.m.)
  • changed from pending to submitted
Committed in revision 417380

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.