Review Board 1.7.16


Install dahdi span hook only if relevant

Review Request #3727 - Created July 8, 2014 and updated

Tzafrir Cohen
/trunk
Reviewers
asterisk-dev
coreyfarrell
Asterisk
Commit r417863 added support for installing a hook script for dahdi under /usr/share/dahdi/span_config.d . This, however, broke support for users setting --prefix=$HOME:

/usr/bin/install -c -d //usr/share/dahdi/span_config.d
/usr/bin/install: cannot create directory ‘//usr/share/dahdi’: Permission denied

Suggested fix: only install the hook prefix is /usr.

Note: installing only if chan_dahdi was enabled is not easy as menuselect.makeopts is not included into the main Makefile.

 
Posted (July 8, 2014, 1:52 p.m.)
I just checked, the Makefile optionally includes makeopts.  It is only optional so the Makefile can print a nice message that you need to ./configure.  This file sets DAHDI_INCLUDE, checking that for non-blank in addition to the check for --prefix would make me very happy.  In general people aren't going to install the dahdi development package then choose to not build chan_dahdi.
  1. DAHDI_INCLUDE gets an empty value on my system (that builds chan_dahdi). I can't see any other way for the makefile to see the result of PBX_DAHDI from autoconf (except a direct sed from build_tools/menuselect-deps).
  2. Sorry as I said I don't have dahdi on my test system so I couldn't see that.  What about adding a new variable in makeopts.in set to @PBX_DAHDI@?

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.