Review Board 1.7.16


better SDP parsing algorithm for 1.4

Review Request #385 - Created Sept. 30, 2009 and submitted

frawd
1.4
0014994
Reviewers
asterisk-dev
mnicholson, oej
Asterisk
This patch cleans up asterisk's SDP parsing algorithm, resolving a few bugs including #14994. It does the parsing line by line, making a distinction between session-level and media-specific parameters. It also optimizes the parsing adding functions for audio/video/image specific scanning.
I added debug information for a better understanding on how the parsing is actually done (shows each SDP line parsed with OK or UNSUPPORTED).

If ported to 1.6 (sorry but I have no idea how the SIP code changed between 1.4 and 1.6 so I don't know how to do it), it will allow to easily add SDP functionality.
Production tested for multiple audio and video devices in a version of the patch for 1.4.26.2 (see bug #14994).

Not tested with T.38, but it should work well.
Review request changed
Updated (Nov. 2, 2009, 8:59 a.m.)
Added a session level ast_hostent structure as jcolp suggested.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.