Review Board 1.7.16


fromdomainport used even if not set

Review Request #3893 - Created Aug. 7, 2014 and submitted

ebroad
trunk
ASTERISK-24178
Reviewers
asterisk-dev
Asterisk
From the issue:

"
Long story short, we set fromdomainport to STANDARD_SIP_PORT if it is not set by the user in fromdomain(see http://doxygen.asterisk.org/trunk/df/df0/chan__sip_8c-source.html#l30599). The issue is, in two places, we do the following:

int ourport = (p->fromdomainport) ? p->fromdomainport : ast_sockaddr_port(&p->ourip);

Which means we will always use fromdomainport even if it wasn't actually set by the user. A side effect of this is when using SIP over TLS, an MWI response will always include port 5060 in the Message-Account field even though TLS uses 5061 (see http://doxygen.asterisk.org/trunk/df/df0/chan__sip_8c-source.html#l15086).

The attached patch resolves this issue.
"
Made and received calls without issue. Tested MWI notifications as well.
Review request changed
Updated (Aug. 28, 2014, 9:19 a.m.)
  • changed from pending to submitted
Committed in revision 422238

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.