Review Board 1.7.16


SIP TCP/TLS: ensure that the contact header properly supports TLS/improved support for PAT/port redirection

Review Request #392 - Created Oct. 5, 2009 and submitted

ebroad
/trunk
15880
Reviewers
asterisk-dev
Asterisk
https://issues.asterisk.org/view.php?id=15880

This patch adds support for TCP/TLS in the Contact header when using NAT, specifically externip or externhost. The original issue was that Asterisk sent 5060 as the port in the contact header whether TLS was used or not. Additionally, this patch adds 2 config options to sip.conf, specifically externtcpport and externtlsport. This allows a user to specify different external ports for TCP and TLS other than those used internally, this is especially useful in in a PAT/port redirection setup. 
Tested both inbound and outbound calls using Counterpath's Bria softphone, with Asterisk behind a NAT firewall(Cisco ASA), and with the appropriate ports redirected. The client was behind a NAT firewall(Cisco PIX), using STUN. 
Review request changed
Updated (Oct. 6, 2009, 12:03 p.m.)
Ship it!
Posted (Oct. 6, 2009, 12:29 p.m.)
Excellent work, this looks great!

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.