Review Board 1.7.16


Menuselect: Fix incorrect enabling on failed deps

Review Request #3975 - Created Sept. 4, 2014 and submitted

opticron
trunk
Reviewers
asterisk-dev
mjordan
Menuselect
This corrects a situation where menuselect can incorrectly enable a module by default that has defaultenabled set to "no" and has failed/non-selected dependencies. The bug is due to an inverted test when checking for whether the given module should be set to enabled by default on load.
Verified that the four modules that fit the requirements for this bug were correctly not enabled when the patch was applied. The modules where I observed this behavior are pbx_ael, chan_jingle, chan_gtalk, and chan_mgcp on the 1.8.28 certified branch.
Total:
1
Open:
0
Resolved:
1
Dropped:
0
Status:
From:
Review request changed
Updated (Sept. 5, 2014, 9:23 a.m.)
  • changed from pending to submitted
Committed in revision 422660

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.