Review Board 1.7.16


better SDP parsing algorithm for trunk

Review Request #414 - Created Oct. 25, 2009 and submitted

frawd
0014994
Reviewers
asterisk-dev
mnicholson, oej
Asterisk
See https://reviewboard.asterisk.org/r/385/ for the initial 1.4 patch.

Changes from 1.4 patch:
- Port to trunk API and its new things (SIREN, T.38, ...)
- Added function "process_sdp_o" for version checking
- Added function "process_sdp_a_text" for T.140 and RED stuff

This patch cleans up asterisk's SDP parsing algorithm, resolving a few bugs including #14994. It does the parsing line by line, making a distinction between session-level and media-specific parameters. It also optimizes the parsing adding functions for audio/video/image specific scanning.
I added debug information for a better understanding on how the parsing is actually done (shows each SDP line parsed with OK or UNSUPPORTED).
It compiles OK.

When I can figure out how to load modules in trunk, I can do some basic testing. But I cannot test that in production (trunk...).
For now I got dozens of:
"Module '*****' could not be loaded."
Review request changed
Updated (Nov. 3, 2009, 4:08 a.m.)
Fixed verbose messages regarding T.140 but referring to video.

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.