Review Board 1.7.16


core: avoid rasterisk crash due to long identifier

Review Request #4182 - Created Nov. 13, 2014 and submitted

Scott Griepentrog
13, trunk
Reviewers
asterisk-dev
Asterisk
When connecting to the remote console, an identifier string is first provided that consists of hostname/pid/version.  This is parsed by the remote instance in a buffer allocated to only 80 bytes.  It is possible for a combination of very long hostname and very long asterisk version number to be greater than 80 characters, causing the parsing to fall off the end of the allocated memory buffer and potentially crash.

This change increases the buffer from 80 to 256 to significantly reduce that possibility.
It stopped crashing on a repeated test I was running where the atoi of the version # happen to hit the end of the buffer.
Total:
1
Open:
0
Resolved:
1
Dropped:
0
Status:
From:
Description From Last Updated Status
Review request changed
Updated (April 1, 2015, 3:33 p.m.)
  • changed from pending to submitted
Committed in revision 433918

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.