Review Board 1.7.16


chan_sip: Simplify dialog/peer references, add REF_DEBUG passthrough of callers to sip_alloc and find_call.

Review Request #4189 - Created March 13, 2015 and submitted

Corey Farrell
13, trunk
ASTERISK-24882
Reviewers
asterisk-dev
Asterisk
This does have a minor change to sip_ref_peer and dialog_ref - the error messages about trying to reference a NULL is removed.  This message provided nothing useful.  The changes to sip_alloc / find_call make it easier to trace REF_DEBUG logs for leaked dialogs.

Note: I've posted the version of this patch for 13.  In trunk the 'struct ast_callid *' type has been replaced with a typedef 'ast_callid', effecting the parameter logger_callid of sip_alloc.
Ran a few testsuite chan_sip tests.  Verified that REF_DEBUG log shows caller of sip_alloc.
Total:
3
Open:
0
Resolved:
3
Dropped:
0
Status:
From:
Review request changed
Updated (March 19, 2015, 5:27 a.m.)
  • changed from pending to submitted
Committed in revision 433139

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.