Review Board 1.7.16


res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'

Review Request #4301 - Created Dec. 29, 2014 and submitted

George Joseph
13
Reviewers
asterisk-dev
opticron, sgriepentrog
Asterisk
The current behavior of 'pjsip send unregister' is to send the unregister (REGISTER with 0 exp) but let the next scheduled register proceed normally.  I don't think that's a good idea.  If you unregister, it should stay unregistered until you decide to start registrations again.  So this patch just adds a cancel_registration call to the current unregister_task to cancel the timer.

Of course, now you need  a way to start registration again so I've added a 'pjsip send register' command that unregisters and cancels any existing registration (the same as send unregister), then sends an immediate registration and starts the timer back up again.

Both changes also ripple to AMI.  There's a new PJSIPRegister command.

There's no harm in calling either command repeatedly.  They don't care about the actual state.

I did discover a previously existing ref count leak for state though.  Every time asterisk sends a register, the count gets incremented but never decremented.  I'll look at this separately.
The current tests/channels/pjsip/registration/outbound/unregister tests run fine.  I'm working on additional tests to exercise the register command.


Review request changed
Updated (Jan. 21, 2015, 1:47 p.m.)
  • changed from pending to submitted
Committed in revision 430898

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.