Review Board 1.7.16


Use SIPS Contact headers as prescribed by RFC 3261 (chan_sip)

Review Request #4346 - Created Jan. 15, 2015 and submitted

Mark Michelson
/branches/11/
ASTERISK-24646
Reviewers
asterisk-dev
Asterisk
Please see the description on /r/4345 for a description of the interoperability problem.

This patch is the chan_sip version of the patch. The chan_sip patch is a bit more weird since creation of Contact headers is not divided into dialog vs. non-dialog situations. For this patch, I have expanded the build_contact() function to base the scheme of the Contact header based on the rules of RFC 3261 sections 8.1.1.8 and 12.1.1. To do this, I have added two parameters so that it is clear whether the Contact header is being created due to a response to an incoming request or if the Contact is being added to a created outgoing request.
This patch has been tested by the reporter of ASTERISK-24646 and has been confirmed to solve the interop issue.
Total:
4
Open:
0
Resolved:
3
Dropped:
1
Status:
From:
Description From Last Updated Status
Review request changed
Updated (Jan. 29, 2015, 3:23 p.m.)
  • changed from pending to submitted
Committed in revision 431443

https://reviewboard.asterisk.org/ runs on a server provided by Digium, Inc. and uses bandwidth donated to the open source Asterisk community by API Digital Communications in Huntsville, AL USA.
Please report problems with this site to asteriskteam@digium.com.